This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Post-merge follow up on fixes suggested in #5319 #5349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfbecker
approved these changes
Aug 23, 2019
Codecov Report
@@ Coverage Diff @@
## master #5349 +/- ##
=======================================
Coverage 46.13% 46.13%
=======================================
Files 735 735
Lines 45263 45263
Branches 2626 2626
=======================================
Hits 20880 20880
Misses 22364 22364
Partials 2019 2019
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the two suggestions made by @felixfbecker in #5319.
Thanks for those!